Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle null in json #166

Merged
merged 2 commits into from
May 3, 2019
Merged

handle null in json #166

merged 2 commits into from
May 3, 2019

Conversation

nicksnyder
Copy link
Owner

Treat null translations in JSON the same as being not present.

fixes #153

@codecov
Copy link

codecov bot commented May 3, 2019

Codecov Report

Merging #166 into master will increase coverage by 1.44%.
The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #166      +/-   ##
==========================================
+ Coverage   69.01%   70.46%   +1.44%     
==========================================
  Files          28       28              
  Lines        2353     2360       +7     
==========================================
+ Hits         1624     1663      +39     
+ Misses        639      609      -30     
+ Partials       90       88       -2
Impacted Files Coverage Δ
v2/internal/message.go 75.43% <92.3%> (+31.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2843f1...accd9a2. Read the comment docs.

@nicksnyder nicksnyder merged commit 030e502 into master May 3, 2019
@nicksnyder nicksnyder deleted the nullinjson branch May 3, 2019 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

null values in json
1 participant